Fixing metadata #11
Merged
Fixing metadata #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbosse
commented
Jul 10, 2024
| test-action: | ||
| name: GitHub Actions Test | ||
| runs-on: ubuntu-latest | ||
| # test-action: |
There was a problem hiding this comment.
I'm not sure how to integration test the action without real endpoints.
jbosse
commented
Jul 10, 2024
| name: 'The name of your action here' | ||
| description: 'Provide a description here' | ||
| author: 'Your name or organization here' | ||
| name: 'dependabot-tickets' |
There was a problem hiding this comment.
I didn't even notice this file before.
and return just the data not a circular response object.
jbosse
commented
Jul 10, 2024
| @@ -29,15 +29,15 @@ class PlanviewClient { | |||
| } | |||
|
|
|||
| #parseResponse(result) { | |||
| if (result.status === 200 && !!result.data.id) { | |||
| if (result.status === 201 && !!result.data.id) { | |||
There was a problem hiding this comment.
I think this was causing it to return the else condition to the Action runner so it was falling even though the ticket was created.
jbosse
commented
Jul 10, 2024
| return { | ||
| success: true, | ||
| data: result.data | ||
| } | ||
| } else { | ||
| return { | ||
| success: false, | ||
| result | ||
| data: result.data |
There was a problem hiding this comment.
I think result was causing an error because the Axios response is circular.
DBugger32
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.